fix: Convert Prometheus floating point numbers correctly to int #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus returns floats as strings, e.g., `16.5` is a valid idletime. This breaks the `int()` parsing since it can't handle floats as strings.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 225 225
Lines 7411 7411
Branches 513 513
=======================================
Hits 6334 6334
Misses 913 913
Partials 164 164 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
API Changelog 4.13.1.dev66+g4ec5ab4c |
zusorio
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus returns floats as strings, e.g.,
"16.5"is a valid idletime. This breaks theint()parsing since it can't handle floats as strings.